Commit 745d9f4a authored by Fedor Pchelkin's avatar Fedor Pchelkin Committed by Richard Weinberger
Browse files

ubi: eba: properly rollback inside self_check_eba 



In case of a memory allocation failure in the volumes loop we can only
process the already allocated scan_eba and fm_eba array elements on the
error path - others are still uninitialized.

Found by Linux Verification Center (linuxtesting.org).

Fixes: 00abf304 ("UBI: Add self_check_eba()")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarFedor Pchelkin <pchelkin@ispras.ru>
Reviewed-by: default avatarZhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
parent 22a40d14

drivers/mtd/ubi/eba.c

+2 −1
Original line number Diff line number Diff line
@@ -1564,6 +1564,7 @@ int self_check_eba(struct ubi_device *ubi, struct ubi_attach_info *ai_fastmap, 
					  GFP_KERNEL);

		if (!fm_eba[i]) {

			ret = -ENOMEM;

			kfree(scan_eba[i]);

			goto out_free;

		}
@@ -1599,7 +1600,7 @@ int self_check_eba(struct ubi_device *ubi, struct ubi_attach_info *ai_fastmap, 
	}



out_free:

	for (i = 0; i < num_volumes; i++) {

	while (--i >= 0) {

		if (!ubi->volumes[i])

			continue;