Commit 747a69a1 authored by Jason-JH.Lin's avatar Jason-JH.Lin Committed by Jassi Brar
Browse files

mailbox: mtk-cmdq: Fix pm_runtime_get_sync() warning in mbox shutdown 



The return value of pm_runtime_get_sync() in cmdq_mbox_shutdown()
will return 1 when pm runtime state is active, and we don't want to
get the warning message in this case.

So we change the return value < 0 for WARN_ON().

Fixes: 8afe816b ("mailbox: mtk-cmdq-mailbox: Implement Runtime PM with autosuspend")
Signed-off-by: default avatarJason-JH.Lin <jason-jh.lin@mediatek.com>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: default avatarJassi Brar <jassisinghbrar@gmail.com>
parent dc48215f

drivers/mailbox/mtk-cmdq-mailbox.c

+1 −1
Original line number Diff line number Diff line
@@ -465,7 +465,7 @@ static void cmdq_mbox_shutdown(struct mbox_chan *chan) 
	struct cmdq_task *task, *tmp;

	unsigned long flags;



	WARN_ON(pm_runtime_get_sync(cmdq->mbox.dev));

	WARN_ON(pm_runtime_get_sync(cmdq->mbox.dev) < 0);



	spin_lock_irqsave(&thread->chan->lock, flags);

	if (list_empty(&thread->task_busy_list))