Commit 74de0eaa authored by Sathishkumar S's avatar Sathishkumar S Committed by Alex Deucher
Browse files

drm/amdgpu: fix bit shift logic 



BIT_ULL(n) sets nth bit, remove explicit shift and set the position

Fixes: a7a411e2 ("drm/amdgpu: fix shift-out-of-bounds in amdgpu_debugfs_jpeg_sched_mask_set")
Signed-off-by: default avatarSathishkumar S <sathishkumar.sundararaju@amd.com>
Reviewed-by: default avatarLeo Liu <leo.liu@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 6917112a

drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c

+1 −1
Original line number Diff line number Diff line
@@ -371,7 +371,7 @@ static int amdgpu_debugfs_jpeg_sched_mask_set(void *data, u64 val) 
	for (i = 0; i < adev->jpeg.num_jpeg_inst; ++i) {

		for (j = 0; j < adev->jpeg.num_jpeg_rings; ++j) {

			ring = &adev->jpeg.inst[i].ring_dec[j];

			if (val & (BIT_ULL(1) << ((i * adev->jpeg.num_jpeg_rings) + j)))

			if (val & (BIT_ULL((i * adev->jpeg.num_jpeg_rings) + j)))

				ring->sched.ready = true;

			else

				ring->sched.ready = false;