Commit 74f19220 authored by Sarthak Sharma's avatar Sarthak Sharma Committed by Shuah Khan
Browse files

selftests: kselftest: fix wrong test number in ksft_exit_skip 

ksft_exit_skip() increments ksft_xskip before printing the KTAP
result. As a result, ksft_test_num() already includes the skipped
test.

Adding 1 to ksft_test_num() increments the printed test number
again, producing an incorrect test number and wrong KTAP output.

Drop the extra increment and print ksft_test_num() directly.

Link: https://lore.kernel.org/r/20260427112447.147985-1-sarthak.sharma@arm.com


Fixes: b85d387c ("kselftest: fix TAP output for skipped tests")
Signed-off-by: default avatarSarthak Sharma <sarthak.sharma@arm.com>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
parent 254f4963

tools/testing/selftests/kselftest.h

+1 −1
Original line number Diff line number Diff line
@@ -450,7 +450,7 @@ static inline __noreturn __printf(1, 2) void ksft_exit_skip(const char *msg, ... 
	 */

	if (ksft_plan || ksft_test_num()) {

		ksft_cnt.ksft_xskip++;

		printf("ok %u # SKIP ", 1 + ksft_test_num());

		printf("ok %u # SKIP ", ksft_test_num());

	} else {

		printf("1..0 # SKIP ");

	}