Commit 74f3931a authored Jul 07, 2025 by Kent Overstreet

bcachefs: Fix additional misalignment in journal space calculations



Additional fix on top of

f54b2a80 bcachefs: Fix misaligned bucket check in journal space calculations

Make sure that when we calculate space for the next entry it's not
misaligned: we need to round_down() to filesystem block size in multiple
places (next entry size calculation as well as total space available).

Reported-by: Ondřej Kraus <neverberlerfellerer@gmail.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

parent 7de3c8b4

fs/bcachefs/journal_reclaim.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -169,6 +169,12 @@ static struct journal_space __journal_space_available(struct journal *j, unsigne
		if (nr_devs < nr_devs_want)
		return (struct journal_space) { 0, 0 };

		/*
		* It's possible for bucket size to be misaligned w.r.t. the filesystem
		* block size:
		*/
		min_bucket_size = round_down(min_bucket_size, block_sectors(c));

		/*
		* We sorted largest to smallest, and we want the smallest out of the
		* @nr_devs_want largest devices: