Commit 751f5246 authored by Baokun Li's avatar Baokun Li Committed by Christian Brauner
Browse files

cachefiles: cancel all requests for the object that is being dropped 



Because after an object is dropped, requests for that object are useless,
cancel them to avoid causing other problems.

This prepares for the later addition of cancel_work_sync(). After the
reopen requests is generated, cancel it to avoid cancel_work_sync()
blocking by waiting for daemon to complete the reopen requests.

Signed-off-by: default avatarBaokun Li <libaokun1@huawei.com>
Link: https://lore.kernel.org/r/20240628062930.2467993-7-libaokun@huaweicloud.com


Acked-by: default avatarJeff Layton <jlayton@kernel.org>
Reviewed-by: default avatarGao Xiang <hsiangkao@linux.alibaba.com>
Reviewed-by: default avatarJia Zhu <zhujia.zj@bytedance.com>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent b2415d1f

fs/cachefiles/ondemand.c

+19 −0
Original line number Diff line number Diff line
@@ -564,12 +564,31 @@ int cachefiles_ondemand_init_object(struct cachefiles_object *object) 


void cachefiles_ondemand_clean_object(struct cachefiles_object *object)

{

	unsigned long index;

	struct cachefiles_req *req;

	struct cachefiles_cache *cache;



	if (!object->ondemand)

		return;



	cachefiles_ondemand_send_req(object, CACHEFILES_OP_CLOSE, 0,

			cachefiles_ondemand_init_close_req, NULL);



	if (!object->ondemand->ondemand_id)

		return;



	/* Cancel all requests for the object that is being dropped. */

	cache = object->volume->cache;

	xa_lock(&cache->reqs);

	cachefiles_ondemand_set_object_dropping(object);

	xa_for_each(&cache->reqs, index, req) {

		if (req->object == object) {

			req->error = -EIO;

			complete(&req->done);

			__xa_erase(&cache->reqs, index);

		}

	}

	xa_unlock(&cache->reqs);

}



int cachefiles_ondemand_init_obj_info(struct cachefiles_object *object,