Commit 7528c97c authored Apr 03, 2025 by Miquel Raynal

mtd: spinand: Use more specific naming for the page read op

SPI operations have been initially described through macros implicitly
implying the use of a single SPI SDR bus. Macros for supporting dual and
quad I/O transfers have been added on top, generally inspired by vendor
naming, followed by DTR operations. Soon we might see octal
and even octal DTR operations as well (including the opcode byte).

Let's clarify what the macro really means by describing the expected bus
topology in the page read macro name.

Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

parent 7e8533b2

drivers/mtd/nand/spi/core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -372,7 +372,7 @@ static int spinand_load_page_op(struct spinand_device *spinand,
		{
		struct nand_device *nand = spinand_to_nand(spinand);
		unsigned int row = nanddev_pos_to_row(nand, &req->pos);
		struct spi_mem_op op = SPINAND_PAGE_READ_OP(row);
		struct spi_mem_op op = SPINAND_PAGE_READ_1S_1S_0_OP(row);

		return spi_mem_exec_op(spinand->spimem, &op);
		}

include/linux/mtd/spinand.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -56,7 +56,7 @@
		SPI_MEM_OP_NO_DUMMY, \
		SPI_MEM_OP_NO_DATA)

		#define SPINAND_PAGE_READ_OP(addr) \
		#define SPINAND_PAGE_READ_1S_1S_0_OP(addr) \
		SPI_MEM_OP(SPI_MEM_OP_CMD(0x13, 1), \
		SPI_MEM_OP_ADDR(3, addr, 1), \
		SPI_MEM_OP_NO_DUMMY, \