Commit 75680b7c authored by Karol Wachowski's avatar Karol Wachowski Committed by Jacek Lawrynowicz
Browse files

accel/ivpu: Correct mutex unlock order in job submission 



The mutex unlock for vdev->submitted_jobs_lock was incorrectly placed
before unlocking file_priv->lock. Change order of unlocks to avoid potential
race conditions.

Fixes: 5bbccada ("accel/ivpu: Abort all jobs after command queue unregister")
Signed-off-by: default avatarKarol Wachowski <karol.wachowski@intel.com>
Reviewed-by: default avatarJeff Hugo <jeff.hugo@oss.qualcomm.com>
Signed-off-by: default avatarJacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Link: https://lore.kernel.org/r/20250425093656.2228168-1-jacek.lawrynowicz@linux.intel.com
parent f2ecc700

drivers/accel/ivpu/ivpu_job.c

+1 −1
Original line number Diff line number Diff line
@@ -681,8 +681,8 @@ static int ivpu_job_submit(struct ivpu_job *job, u8 priority, u32 cmdq_id) 
err_erase_xa:

	xa_erase(&vdev->submitted_jobs_xa, job->job_id);

err_unlock:

	mutex_unlock(&vdev->submitted_jobs_lock);

	mutex_unlock(&file_priv->lock);

	mutex_unlock(&vdev->submitted_jobs_lock);

	ivpu_rpm_put(vdev);

	return ret;

}