Commit 756e34da authored by Jose E. Marchesi's avatar Jose E. Marchesi Committed by Alexei Starovoitov
Browse files

bpf: fix constraint in test_tcpbpf_kern.c 



GCC emits a warning:

  progs/test_tcpbpf_kern.c:60:9: error: ‘op’ is used uninitialized [-Werror=uninitialized]

when an uninialized op is used with a "+r" constraint.  The + modifier
means a read-write operand, but that operand in the selftest is just
written to.

This patch changes the selftest to use a "=r" constraint.  This
pacifies GCC.

Tested in bpf-next master.
No regressions.

Signed-off-by: default avatarJose E. Marchesi <jose.marchesi@oracle.com>
Cc: Yonghong Song <yhs@meta.com>
Cc: Eduard Zingerman <eddyz87@gmail.com>
Cc: david.faust@oracle.com
Cc: cupertino.miranda@oracle.com
Acked-by: default avatarYonghong Song <yonghong.song@linux.dev>
Link: https://lore.kernel.org/r/20240123205624.14746-1-jose.marchesi@oracle.com


Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parent edb79903

tools/testing/selftests/bpf/progs/test_tcpbpf_kern.c

+1 −1
Original line number Diff line number Diff line
@@ -59,7 +59,7 @@ int bpf_testcb(struct bpf_sock_ops *skops) 


	asm volatile (

		"%[op] = *(u32 *)(%[skops] +96)"

		: [op] "+r"(op)

		: [op] "=r"(op)

		: [skops] "r"(skops)

		:);