Commit 757259db authored by Bartosz Golaszewski's avatar Bartosz Golaszewski Committed by Johannes Berg
Browse files

ssb: use new GPIO line value setter callbacks 



struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://patch.msgid.link/20250610-gpiochip-set-rv-ssb-v1-1-0bee5b45b411@linaro.org


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 9410e289

drivers/ssb/driver_gpio.c

+5 −3
Original line number Diff line number Diff line
@@ -45,12 +45,14 @@ static int ssb_gpio_chipco_get_value(struct gpio_chip *chip, unsigned int gpio) 
	return !!ssb_chipco_gpio_in(&bus->chipco, 1 << gpio);

}



static void ssb_gpio_chipco_set_value(struct gpio_chip *chip, unsigned int gpio,

static int ssb_gpio_chipco_set_value(struct gpio_chip *chip, unsigned int gpio,

				     int value)

{

	struct ssb_bus *bus = gpiochip_get_data(chip);



	ssb_chipco_gpio_out(&bus->chipco, 1 << gpio, value ? 1 << gpio : 0);



	return 0;

}



static int ssb_gpio_chipco_direction_input(struct gpio_chip *chip,
@@ -223,7 +225,7 @@ static int ssb_gpio_chipco_init(struct ssb_bus *bus) 
	chip->request		= ssb_gpio_chipco_request;

	chip->free		= ssb_gpio_chipco_free;

	chip->get		= ssb_gpio_chipco_get_value;

	chip->set		= ssb_gpio_chipco_set_value;

	chip->set_rv		= ssb_gpio_chipco_set_value;

	chip->direction_input	= ssb_gpio_chipco_direction_input;

	chip->direction_output	= ssb_gpio_chipco_direction_output;

#if IS_ENABLED(CONFIG_SSB_EMBEDDED)