Unverified Commit 75cc23ff authored by Dan Carpenter's avatar Dan Carpenter Committed by Rodrigo Vivi
Browse files

drm/xe: Fix a NULL vs IS_ERR() in xe_vm_add_compute_exec_queue() 



The xe_preempt_fence_create() function returns error pointers.  It
never returns NULL.  Update the error checking to match.

Fixes: dd08ebf6 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarMatthew Brost <matthew.brost@intel.com>
Link: https://lore.kernel.org/r/aJTMBdX97cof_009@stanley.mountain


Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent d4c3ed96

drivers/gpu/drm/xe/xe_vm.c

+2 −2
Original line number Diff line number Diff line
@@ -224,8 +224,8 @@ int xe_vm_add_compute_exec_queue(struct xe_vm *vm, struct xe_exec_queue *q) 


	pfence = xe_preempt_fence_create(q, q->lr.context,

					 ++q->lr.seqno);

	if (!pfence) {

		err = -ENOMEM;

	if (IS_ERR(pfence)) {

		err = PTR_ERR(pfence);

		goto out_fini;

	}