Commit 75e4c6bc authored by Yu Jiaoliang's avatar Yu Jiaoliang Committed by Christian Brauner
Browse files

mnt_idmapping: Use kmemdup_array instead of kmemdup for multiple allocation 



Let the kememdup_array() take care about multiplication and possible
overflows.

v2:Add a new modification for reverse array.

Signed-off-by: default avatarYu Jiaoliang <yujiaoliang@vivo.com>
Link: https://lore.kernel.org/r/20240823015542.3006262-1-yujiaoliang@vivo.com


Reviewed-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 3c58a957

fs/mnt_idmapping.c

+6 −6
Original line number Diff line number Diff line
@@ -228,14 +228,14 @@ static int copy_mnt_idmap(struct uid_gid_map *map_from, 
		return 0;

	}



	forward = kmemdup(map_from->forward,

			  nr_extents * sizeof(struct uid_gid_extent),

	forward = kmemdup_array(map_from->forward, nr_extents,

				sizeof(struct uid_gid_extent),

				GFP_KERNEL_ACCOUNT);

	if (!forward)

		return -ENOMEM;



	reverse = kmemdup(map_from->reverse,

			  nr_extents * sizeof(struct uid_gid_extent),

	reverse = kmemdup_array(map_from->reverse, nr_extents,

				sizeof(struct uid_gid_extent),

				GFP_KERNEL_ACCOUNT);

	if (!reverse) {

		kfree(forward);