Commit 760b9b4f authored by Thomas Fourier's avatar Thomas Fourier Committed by Madhavan Srinivasan
Browse files

(powerpc/512) Fix possible `dma_unmap_single()` on uninitialized pointer 



If the device configuration fails (if `dma_dev->device_config()`),
`sg_dma_address(&sg)` is not initialized and the jump to `err_dma_prep`
leads to calling `dma_unmap_single()` on `sg_dma_address(&sg)`.

Signed-off-by: default avatarThomas Fourier <fourier.thomas@gmail.com>
Reviewed-by: default avatarChristophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: default avatarMadhavan Srinivasan <maddy@linux.ibm.com>
Link: https://patch.msgid.link/20250610142918.169540-2-fourier.thomas@gmail.com
parent cf183c17

arch/powerpc/platforms/512x/mpc512x_lpbfifo.c

+2 −4
Original line number Diff line number Diff line
@@ -240,10 +240,8 @@ static int mpc512x_lpbfifo_kick(void) 
	dma_conf.src_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;



	/* Make DMA channel work with LPB FIFO data register */

	if (dma_dev->device_config(lpbfifo.chan, &dma_conf)) {

		ret = -EINVAL;

		goto err_dma_prep;

	}

	if (dma_dev->device_config(lpbfifo.chan, &dma_conf))

		return -EINVAL;



	sg_init_table(&sg, 1);