Unverified Commit 761bea18 authored by Dr. David Alan Gilbert's avatar Dr. David Alan Gilbert Committed by Ilpo Järvinen
Browse files

platform/x86: intel: punit_ipc: Remove unused function 



intel_punit_ipc_simple_command() was added in 2015 by
commit fdca4f16 ("platform:x86: add Intel P-Unit mailbox IPC driver")
but never used.

Remove it.

Signed-off-by: default avatarDr. David Alan Gilbert <linux@treblig.org>
Link: https://lore.kernel.org/r/20241221234807.160473-1-linux@treblig.org


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent a5ddea4f

arch/x86/include/asm/intel_punit_ipc.h

+0 −7
Original line number Diff line number Diff line
@@ -80,17 +80,10 @@ typedef enum { 


#if IS_ENABLED(CONFIG_INTEL_PUNIT_IPC)



int intel_punit_ipc_simple_command(int cmd, int para1, int para2);

int intel_punit_ipc_command(u32 cmd, u32 para1, u32 para2, u32 *in, u32 *out);



#else



static inline int intel_punit_ipc_simple_command(int cmd,

						  int para1, int para2)

{

	return -ENODEV;

}



static inline int intel_punit_ipc_command(u32 cmd, u32 para1, u32 para2,

					  u32 *in, u32 *out)

{

drivers/platform/x86/intel/punit_ipc.c

+0 −33
Original line number Diff line number Diff line
@@ -130,39 +130,6 @@ static int intel_punit_ipc_check_status(IPC_DEV *ipcdev, IPC_TYPE type) 
	return 0;

}



/**

 * intel_punit_ipc_simple_command() - Simple IPC command

 * @cmd:	IPC command code.

 * @para1:	First 8bit parameter, set 0 if not used.

 * @para2:	Second 8bit parameter, set 0 if not used.

 *

 * Send a IPC command to P-Unit when there is no data transaction

 *

 * Return:	IPC error code or 0 on success.

 */

int intel_punit_ipc_simple_command(int cmd, int para1, int para2)

{

	IPC_DEV *ipcdev = punit_ipcdev;

	IPC_TYPE type;

	u32 val;

	int ret;



	mutex_lock(&ipcdev->lock);



	reinit_completion(&ipcdev->cmd_complete);

	type = (cmd & IPC_PUNIT_CMD_TYPE_MASK) >> IPC_TYPE_OFFSET;



	val = cmd & ~IPC_PUNIT_CMD_TYPE_MASK;

	val |= CMD_RUN | para2 << CMD_PARA2_SHIFT | para1 << CMD_PARA1_SHIFT;

	ipc_write_cmd(ipcdev, type, val);

	ret = intel_punit_ipc_check_status(ipcdev, type);



	mutex_unlock(&ipcdev->lock);



	return ret;

}

EXPORT_SYMBOL(intel_punit_ipc_simple_command);



/**

 * intel_punit_ipc_command() - IPC command with data and pointers

 * @cmd:	IPC command code.