Commit 7621db4d authored by Maxime Ripard's avatar Maxime Ripard Committed by Dave Stevenson
Browse files

drm/vc4: hvs: Change prototype of __vc4_hvs_alloc to pass registers 



The BCM2712 HVS has registers to report the size of the various SRAM the
driver uses, and their size actually differ depending on the stepping.

The initialisation of the memory pools happen in the __vc4_hvs_alloc()
function that also allocates the main HVS structure, that will then hold
the pointer to the memory mapping of the registers.

This creates some kind of circular dependency that we can break by
passing the mapping pointer as an argument for __vc4_hvs_alloc() to use
to query to get the SRAM sizes and initialise the memory pools
accordingly.

Signed-off-by: default avatarMaxime Ripard <mripard@kernel.org>
Reviewed-by: default avatarMaxime Ripard <mripard@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240621152055.4180873-29-dave.stevenson@raspberrypi.com


Signed-off-by: default avatarDave Stevenson <dave.stevenson@raspberrypi.com>
parent 74c3b7c6

drivers/gpu/drm/vc4/tests/vc4_mock.c

+1 −1
Original line number Diff line number Diff line
@@ -175,7 +175,7 @@ static struct vc4_dev *__mock_device(struct kunit *test, enum vc4_gen gen) 
	vc4->dev = dev;

	vc4->gen = gen;



	vc4->hvs = __vc4_hvs_alloc(vc4, NULL);

	vc4->hvs = __vc4_hvs_alloc(vc4, NULL, NULL);

	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, vc4->hvs);



	drm = &vc4->base;

drivers/gpu/drm/vc4/vc4_drv.h

+3 −1
Original line number Diff line number Diff line
@@ -1004,7 +1004,9 @@ void vc4_irq_reset(struct drm_device *dev); 


/* vc4_hvs.c */

extern struct platform_driver vc4_hvs_driver;

struct vc4_hvs *__vc4_hvs_alloc(struct vc4_dev *vc4, struct platform_device *pdev);

struct vc4_hvs *__vc4_hvs_alloc(struct vc4_dev *vc4,

				void __iomem *regs,

				struct platform_device *pdev);

void vc4_hvs_stop_channel(struct vc4_hvs *hvs, unsigned int output);

int vc4_hvs_get_fifo_from_output(struct vc4_hvs *hvs, unsigned int output);

u8 vc4_hvs_get_fifo_frame_count(struct vc4_hvs *hvs, unsigned int fifo);

drivers/gpu/drm/vc4/vc4_hvs.c

+10 −6
Original line number Diff line number Diff line
@@ -811,7 +811,9 @@ int vc4_hvs_debugfs_init(struct drm_minor *minor) 
	return 0;

}



struct vc4_hvs *__vc4_hvs_alloc(struct vc4_dev *vc4, struct platform_device *pdev)

struct vc4_hvs *__vc4_hvs_alloc(struct vc4_dev *vc4,

				void __iomem *regs,

				struct platform_device *pdev)

{

	struct drm_device *drm = &vc4->base;

	struct vc4_hvs *hvs;
@@ -821,6 +823,7 @@ struct vc4_hvs *__vc4_hvs_alloc(struct vc4_dev *vc4, struct platform_device *pde 
		return ERR_PTR(-ENOMEM);



	hvs->vc4 = vc4;

	hvs->regs = regs;

	hvs->pdev = pdev;



	spin_lock_init(&hvs->mm_lock);
@@ -1017,16 +1020,17 @@ static int vc4_hvs_bind(struct device *dev, struct device *master, void *data) 
	struct drm_device *drm = dev_get_drvdata(master);

	struct vc4_dev *vc4 = to_vc4_dev(drm);

	struct vc4_hvs *hvs = NULL;

	void __iomem *regs;

	int ret;



	hvs = __vc4_hvs_alloc(vc4, NULL);

	regs = vc4_ioremap_regs(pdev, 0);

	if (IS_ERR(regs))

		return PTR_ERR(regs);



	hvs = __vc4_hvs_alloc(vc4, regs, pdev);

	if (IS_ERR(hvs))

		return PTR_ERR(hvs);



	hvs->regs = vc4_ioremap_regs(pdev, 0);

	if (IS_ERR(hvs->regs))

		return PTR_ERR(hvs->regs);



	hvs->regset.base = hvs->regs;

	hvs->regset.regs = vc4_hvs_regs;

	hvs->regset.nregs = ARRAY_SIZE(vc4_hvs_regs);