Commit 76385d49 authored by Marek Szyprowski's avatar Marek Szyprowski Committed by Dmitry Baryshkov
Browse files

drm/debugfs: fix potential NULL pointer dereference 



encoder->funcs entry might be NULL, so check it first before calling its
methods. This fixes NULL pointer dereference observed on Rasberry Pi
3b/4b boards.

Fixes: caf525ed ("drm/encoder: register per-encoder debugfs dir")
Signed-off-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Tested-by: default avatarNishanth Menon <nm@ti.com>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20231205130631.3456986-1-m.szyprowski@samsung.com
parent 812cc1da

drivers/gpu/drm/drm_debugfs.c

+1 −1
Original line number Diff line number Diff line
@@ -638,7 +638,7 @@ void drm_debugfs_encoder_add(struct drm_encoder *encoder) 
	debugfs_create_file("bridges", 0444, root, encoder,

			    &bridges_fops);



	if (encoder->funcs->debugfs_init)

	if (encoder->funcs && encoder->funcs->debugfs_init)

		encoder->funcs->debugfs_init(encoder, root);

}