Unverified Commit 76439787 authored by John Madieu's avatar John Madieu Committed by Mark Brown
Browse files

spi: rockchip: Drop unused and broken CR0 macros 



Two CTRLR0 macros are defined but never referenced, and both are wrong:

 - CR0_XFM_MASK shifts by SPI_XFM_OFFSET, which does not exist anywhere
   in the tree. The intended symbol is CR0_XFM_OFFSET.

 - CR0_MTM_OFFSET is defined as 0x21, i.e. bit 33 of a 32-bit register.
   The value is meaningless and the macro is unused.

Drop both. They can be re-introduced correctly when an actual user
appears.

Signed-off-by: default avatarJohn Madieu <john.madieu@gmail.com>
Link: https://patch.msgid.link/20260425092936.2590132-3-john.madieu@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent b4683a23

drivers/spi/spi-rockchip.c

+0 −3
Original line number Diff line number Diff line
@@ -98,7 +98,6 @@ 
#define CR0_FRF_MICROWIRE			0x2



#define CR0_XFM_OFFSET				18

#define CR0_XFM_MASK				(0x03 << SPI_XFM_OFFSET)

#define CR0_XFM_TR					0x0

#define CR0_XFM_TO					0x1

#define CR0_XFM_RO					0x2
@@ -109,8 +108,6 @@ 


#define CR0_SOI_OFFSET				23



#define CR0_MTM_OFFSET				0x21



/* Bit fields in SER, 2bit */

#define SER_MASK					0x3