Commit 764d9561 authored by Josh Poimboeuf's avatar Josh Poimboeuf Committed by Peter Zijlstra
Browse files

objtool: Remove --unret dependency on --rethunk 



With unret validation enabled and IBT/LTO disabled, objtool runs on TUs
with --rethunk and on vmlinux.o with --unret.  So this dependency isn't
valid as they don't always run on the same object.

This error never triggered before because --unret is always coupled with
--noinstr, so the first conditional in opts_valid() returns early due to
opts.noinstr being true.

Signed-off-by: default avatarJosh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/c6f5635784a28ed4b10ac4307b1858e015e6eff0.1741975349.git.jpoimboe@kernel.org
parent 0a7fb6f0

tools/objtool/builtin-check.c

+0 −5
Original line number Diff line number Diff line
@@ -151,11 +151,6 @@ static bool opts_valid(void) 
		return true;

	}



	if (opts.unret && !opts.rethunk) {

		ERROR("--unret requires --rethunk");

		return false;

	}



	if (opts.dump_orc)

		return true;