Commit 765f253e authored by Christian Heusel's avatar Christian Heusel Committed by Jakub Kicinski
Browse files

Revert "rndis_host: Flag RNDIS modems as WWAN devices" 

This reverts commit 67d1a895. Since this
commit has been proven to be problematic for the setup of USB-tethered
ethernet connections and the related breakage is very noticeable for
users it should be reverted until a fixed version of the change can be
rolled out.

Closes: https://lore.kernel.org/all/e0df2d85-1296-4317-b717-bd757e3ab928@heusel.eu/
Link: https://chaos.social/@gromit/114377862699921553
Link: https://bugzilla.kernel.org/show_bug.cgi?id=220002
Link: https://bugs.gentoo.org/953555
Link: https://bbs.archlinux.org/viewtopic.php?id=304892


Cc: stable@vger.kernel.org
Acked-by: default avatarLubomir Rintel <lkundrak@v3.sk>
Signed-off-by: default avatarChristian Heusel <christian@heusel.eu>
Link: https://patch.msgid.link/20250424-usb-tethering-fix-v1-1-b65cf97c740e@heusel.eu


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent bf9de1dc

drivers/net/usb/rndis_host.c

+2 −14
Original line number Diff line number Diff line
@@ -630,16 +630,6 @@ static const struct driver_info zte_rndis_info = { 
	.tx_fixup =	rndis_tx_fixup,

};



static const struct driver_info	wwan_rndis_info = {

	.description =	"Mobile Broadband RNDIS device",

	.flags =	FLAG_WWAN | FLAG_POINTTOPOINT | FLAG_FRAMING_RN | FLAG_NO_SETINT,

	.bind =		rndis_bind,

	.unbind =	rndis_unbind,

	.status =	rndis_status,

	.rx_fixup =	rndis_rx_fixup,

	.tx_fixup =	rndis_tx_fixup,

};



/*-------------------------------------------------------------------------*/



static const struct usb_device_id	products [] = {
@@ -676,11 +666,9 @@ static const struct usb_device_id products [] = { 
	USB_INTERFACE_INFO(USB_CLASS_WIRELESS_CONTROLLER, 1, 3),

	.driver_info = (unsigned long) &rndis_info,

}, {

	/* Mobile Broadband Modem, seen in Novatel Verizon USB730L and

	 * Telit FN990A (RNDIS)

	 */

	/* Novatel Verizon USB730L */

	USB_INTERFACE_INFO(USB_CLASS_MISC, 4, 1),

	.driver_info = (unsigned long)&wwan_rndis_info,

	.driver_info = (unsigned long) &rndis_info,

},

	{ },		// END

};