Commit 767412f0 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Bartosz Golaszewski
Browse files

gpiolib: Simplify implementation of for_each_hwgpio_in_range() 



The whole purpose of the custom CLASS() is to have possibility
to initialise the counter variable _i to 0. This can't be done
with simple __free() macro as it will be not allowed by C language.
OTOH, the CLASS() operates with the pointers and explicit usage of
the scoped variable _data is not needed, since the pointers are kept
the same over the iterations. Simplify the implementation of
for_each_hwgpio_in_range().

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20250207151149.2119765-3-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 88935160

include/linux/gpio/driver.h

+3 −5
Original line number Diff line number Diff line
@@ -560,11 +560,9 @@ DEFINE_CLASS(_gpiochip_for_each_data, 
 */

#define for_each_hwgpio_in_range(_chip, _i, _base, _size, _label)			\

	for (CLASS(_gpiochip_for_each_data, _data)(&_label, &_i);			\

	     *_data.i < _size;								\

	     (*_data.i)++, kfree(*(_data.label)), *_data.label = NULL)			\

		if (IS_ERR(*_data.label =						\

			gpiochip_dup_line_label(_chip, _base + *_data.i))) {}		\

		else

	     _i < _size;								\

	     _i++, kfree(_label), _label = NULL)					\

		if (IS_ERR(_label = gpiochip_dup_line_label(_chip, _base + _i))) {} else



/**

 * for_each_hwgpio - Iterates over all GPIOs for given chip.