Commit 7675361f authored Dec 05, 2024 by John Stultz Committed by Peter Zijlstra Dec 10, 2024

sched: deadline: Cleanup goto label in pick_earliest_pushable_dl_task



Commit 8b5e770e ("sched/deadline: Optimize pull_dl_task()")
added a goto label seems would be better written as a while
loop.

So replace the goto with a while loop, to make it easier to read.

Reported-by: Todd Kjos <tkjos@google.com>
Signed-off-by: John Stultz <jstultz@google.com>
Reviewed-and-tested-by: K Prateek Nayak <kprateek.nayak@amd.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Juri Lelli <juri.lelli@redhat.com>
Link: https://lore.kernel.org/r/20241206000009.1226085-1-jstultz@google.com

parent 7d5265ff

kernel/sched/deadline.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -2516,16 +2516,13 @@ static struct task_struct pick_earliest_pushable_dl_task(struct rq rq, int cpu
		return NULL;

		next_node = rb_first_cached(&rq->dl.pushable_dl_tasks_root);

		next_node:
		if (next_node) {
		while (next_node) {
		p = __node_2_pdl(next_node);

		if (task_is_pushable(rq, p, cpu))
		return p;

		next_node = rb_next(next_node);
		goto next_node;
		}

		return NULL;