Commit 7675b5ef authored by Mikael Gonella-Bolduc's avatar Mikael Gonella-Bolduc Committed by Dmitry Torokhov
Browse files

Input: cyttsp5 - fix power control issue on wakeup 



The power control function ignores the "on" argument when setting the
report ID, and thus is always sending HID_POWER_SLEEP. This causes a
problem when trying to wakeup.

Fix by sending the state variable, which contains the proper HID_POWER_ON or
HID_POWER_SLEEP based on the "on" argument.

Fixes: 3c98b8db ("Input: cyttsp5 - implement proper sleep and wakeup procedures")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarMikael Gonella-Bolduc <mgonellabolduc@dimonoff.com>
Signed-off-by: default avatarHugo Villeneuve <hvilleneuve@dimonoff.com>
Reviewed-by: default avatarAlistair Francis <alistair@alistair23.me>
Link: https://lore.kernel.org/r/20250423135243.1261460-1-hugo@hugovil.com


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 6a10a2f1

drivers/input/touchscreen/cyttsp5.c

+1 −1
Original line number Diff line number Diff line
@@ -580,7 +580,7 @@ static int cyttsp5_power_control(struct cyttsp5 *ts, bool on) 
	int rc;



	SET_CMD_REPORT_TYPE(cmd[0], 0);

	SET_CMD_REPORT_ID(cmd[0], HID_POWER_SLEEP);

	SET_CMD_REPORT_ID(cmd[0], state);

	SET_CMD_OPCODE(cmd[1], HID_CMD_SET_POWER);



	rc = cyttsp5_write(ts, HID_COMMAND_REG, cmd, sizeof(cmd));