Commit 767b74e0 authored by Zijun Hu's avatar Zijun Hu Committed by Greg Kroah-Hartman
Browse files

driver core: Introduce device_iter_t for device iterating APIs 



There are several for_each APIs which has parameter with type below:
int (*fn)(struct device *dev, void *data)
They iterate over various device lists and call @fn() for each device
with caller provided data @*data, and they usually need to modify @*data.

Give the type an dedicated typedef with advantages shown below:
typedef int (*device_iter_t)(struct device *dev, void *data)

- Shorter API declarations and definitions
- Prevent further for_each APIs from using bad parameter type

So introduce device_iter_t and apply it to various existing APIs below:
bus_for_each_dev()
(class|driver)_for_each_device()
device_for_each_child(_reverse|_reverse_from)().

Reviewed-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarZijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/r/20250105-class_fix-v6-7-3a2f1768d4d4@quicinc.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 523c6b3e

drivers/base/bus.c

+1 −1
Original line number Diff line number Diff line
@@ -354,7 +354,7 @@ static struct device *next_device(struct klist_iter *i) 
 * count in the supplied callback.

 */

int bus_for_each_dev(const struct bus_type *bus, struct device *start,

		     void *data, int (*fn)(struct device *, void *))

		     void *data, device_iter_t fn)

{

	struct subsys_private *sp = bus_to_subsys(bus);

	struct klist_iter i;

drivers/base/class.c

+1 −1
Original line number Diff line number Diff line
@@ -402,7 +402,7 @@ EXPORT_SYMBOL_GPL(class_dev_iter_exit); 
 * code.  There's no locking restriction.

 */

int class_for_each_device(const struct class *class, const struct device *start,

			  void *data, int (*fn)(struct device *, void *))

			  void *data, device_iter_t fn)

{

	struct subsys_private *sp = class_to_subsys(class);

	struct class_dev_iter iter;

drivers/base/core.c

+3 −3
Original line number Diff line number Diff line
@@ -3980,7 +3980,7 @@ const char *device_get_devnode(const struct device *dev, 
 * other than 0, we break out and return that value.

 */

int device_for_each_child(struct device *parent, void *data,

			  int (*fn)(struct device *dev, void *data))

			  device_iter_t fn)

{

	struct klist_iter i;

	struct device *child;
@@ -4010,7 +4010,7 @@ EXPORT_SYMBOL_GPL(device_for_each_child); 
 * other than 0, we break out and return that value.

 */

int device_for_each_child_reverse(struct device *parent, void *data,

				  int (*fn)(struct device *dev, void *data))

				  device_iter_t fn)

{

	struct klist_iter i;

	struct device *child;
@@ -4044,7 +4044,7 @@ EXPORT_SYMBOL_GPL(device_for_each_child_reverse); 
 */

int device_for_each_child_reverse_from(struct device *parent,

				       struct device *from, void *data,

				       int (*fn)(struct device *, void *))

				       device_iter_t fn)

{

	struct klist_iter i;

	struct device *child;

drivers/base/driver.c

+1 −1
Original line number Diff line number Diff line
@@ -115,7 +115,7 @@ EXPORT_SYMBOL_GPL(driver_set_override); 
 * Iterate over the @drv's list of devices calling @fn for each one.

 */

int driver_for_each_device(struct device_driver *drv, struct device *start,

			   void *data, int (*fn)(struct device *, void *))

			   void *data, device_iter_t fn)

{

	struct klist_iter i;

	struct device *dev;

include/linux/device.h

+3 −3
Original line number Diff line number Diff line
@@ -1075,12 +1075,12 @@ void device_del(struct device *dev); 
DEFINE_FREE(device_del, struct device *, if (_T) device_del(_T))



int device_for_each_child(struct device *parent, void *data,

			  int (*fn)(struct device *dev, void *data));

			  device_iter_t fn);

int device_for_each_child_reverse(struct device *parent, void *data,

				  int (*fn)(struct device *dev, void *data));

				  device_iter_t fn);

int device_for_each_child_reverse_from(struct device *parent,

				       struct device *from, void *data,

				       int (*fn)(struct device *, void *));

				       device_iter_t fn);

struct device *device_find_child(struct device *parent, const void *data,

				 device_match_t match);

struct device *device_find_child_by_name(struct device *parent,