Commit 76b72736 authored by Brandon Wyman's avatar Brandon Wyman Committed by Guenter Roeck
Browse files

hwmon: (pmbus/ibm-cffps) Fix write bits for LED control 



When doing a PMBus write for the LED control on the IBM Common Form
Factor Power Supplies (ibm-cffps), the DAh command requires that bit 7
be low and bit 6 be high in order to indicate that you are truly
attempting to do a write.

Signed-off-by: default avatarBrandon Wyman <bjwyman@gmail.com>
Link: https://lore.kernel.org/r/20210806225131.1808759-1-bjwyman@gmail.com


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 2284ed9f

drivers/hwmon/pmbus/ibm-cffps.c

+3 −3
Original line number Diff line number Diff line
@@ -50,9 +50,9 @@ 
#define CFFPS_MFR_VAUX_FAULT			BIT(6)

#define CFFPS_MFR_CURRENT_SHARE_WARNING		BIT(7)



#define CFFPS_LED_BLINK				BIT(0)

#define CFFPS_LED_ON				BIT(1)

#define CFFPS_LED_OFF				BIT(2)

#define CFFPS_LED_BLINK				(BIT(0) | BIT(6))

#define CFFPS_LED_ON				(BIT(1) | BIT(6))

#define CFFPS_LED_OFF				(BIT(2) | BIT(6))

#define CFFPS_BLINK_RATE_MS			250



enum {