Commit 76d1eb09 authored by Markuss Broks's avatar Markuss Broks Committed by Jonathan Cameron
Browse files

proximity: vl53l0x: Prefer pre-initialized interrupt flags 



On some boards interrupt type might be different than falling edge,
like hardcoded in driver. Leave interrupt flags as they were pre-configured
from the device-tree. If they're not provided, default to falling edge
interrupts.

Signed-off-by: default avatarMarkuss Broks <markuss.broks@gmail.com>
Link: https://lore.kernel.org/r/20220523175344.5845-3-markuss.broks@gmail.com


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 2b920896

drivers/iio/proximity/vl53l0x-i2c.c

+6 −1
Original line number Diff line number Diff line
@@ -16,6 +16,7 @@ 


#include <linux/delay.h>

#include <linux/i2c.h>

#include <linux/irq.h>

#include <linux/interrupt.h>

#include <linux/module.h>
@@ -57,11 +58,15 @@ static irqreturn_t vl53l0x_handle_irq(int irq, void *priv) 
static int vl53l0x_configure_irq(struct i2c_client *client,

				 struct iio_dev *indio_dev)

{

	int irq_flags = irq_get_trigger_type(client->irq);

	struct vl53l0x_data *data = iio_priv(indio_dev);

	int ret;



	if (!irq_flags)

		irq_flags = IRQF_TRIGGER_FALLING;



	ret = devm_request_irq(&client->dev, client->irq, vl53l0x_handle_irq,

			IRQF_TRIGGER_FALLING, indio_dev->name, indio_dev);

			irq_flags, indio_dev->name, indio_dev);

	if (ret) {

		dev_err(&client->dev, "devm_request_irq error: %d\n", ret);

		return ret;