Commit 76d749c5 authored by Sunil V L's avatar Sunil V L Committed by Rafael J. Wysocki
Browse files

ACPI: scan: Refactor dependency creation 



Some architectures like RISC-V will use implicit dependencies like GSI
map to create dependencies between interrupt controller and devices. To
support doing that, the function which creates the dependency, is
refactored bit and made public so that dependency can be added from
outside of scan.c as well.

Signed-off-by: default avatarSunil V L <sunilvl@ventanamicro.com>
Tested-by: default avatarBjörn Töpel <bjorn@rivosinc.com>
Link: https://patch.msgid.link/20240812005929.113499-5-sunilvl@ventanamicro.com


Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent f7d7ccf9

drivers/acpi/scan.c

+47 −39
Original line number Diff line number Diff line
@@ -2013,52 +2013,18 @@ void acpi_scan_hotplug_enabled(struct acpi_hotplug_profile *hotplug, bool val) 
	mutex_unlock(&acpi_scan_lock);

}



static void acpi_scan_init_hotplug(struct acpi_device *adev)

{

	struct acpi_hardware_id *hwid;



	if (acpi_dock_match(adev->handle) || is_ejectable_bay(adev)) {

		acpi_dock_add(adev);

		return;

	}

	list_for_each_entry(hwid, &adev->pnp.ids, list) {

		struct acpi_scan_handler *handler;



		handler = acpi_scan_match_handler(hwid->id, NULL);

		if (handler) {

			adev->flags.hotplug_notify = true;

			break;

		}

	}

}



static u32 acpi_scan_check_dep(acpi_handle handle)

int acpi_scan_add_dep(acpi_handle handle, struct acpi_handle_list *dep_devices)

{

	struct acpi_handle_list dep_devices;

	u32 count;

	int i;



	/*

	 * Check for _HID here to avoid deferring the enumeration of:

	 * 1. PCI devices.

	 * 2. ACPI nodes describing USB ports.

	 * Still, checking for _HID catches more then just these cases ...

	 */

	if (!acpi_has_method(handle, "_DEP") || !acpi_has_method(handle, "_HID"))

		return 0;



	if (!acpi_evaluate_reference(handle, "_DEP", NULL, &dep_devices)) {

		acpi_handle_debug(handle, "Failed to evaluate _DEP.\n");

		return 0;

	}



	for (count = 0, i = 0; i < dep_devices.count; i++) {

	for (count = 0, i = 0; i < dep_devices->count; i++) {

		struct acpi_device_info *info;

		struct acpi_dep_data *dep;

		bool skip, honor_dep;

		acpi_status status;



		status = acpi_get_object_info(dep_devices.handles[i], &info);

		status = acpi_get_object_info(dep_devices->handles[i], &info);

		if (ACPI_FAILURE(status)) {

			acpi_handle_debug(handle, "Error reading _DEP device info\n");

			continue;
@@ -2077,7 +2043,7 @@ static u32 acpi_scan_check_dep(acpi_handle handle) 


		count++;



		dep->supplier = dep_devices.handles[i];

		dep->supplier = dep_devices->handles[i];

		dep->consumer = handle;

		dep->honor_dep = honor_dep;
@@ -2086,7 +2052,49 @@ static u32 acpi_scan_check_dep(acpi_handle handle) 
		mutex_unlock(&acpi_dep_list_lock);

	}



	acpi_handle_list_free(&dep_devices);

	acpi_handle_list_free(dep_devices);

	return count;

}



static void acpi_scan_init_hotplug(struct acpi_device *adev)

{

	struct acpi_hardware_id *hwid;



	if (acpi_dock_match(adev->handle) || is_ejectable_bay(adev)) {

		acpi_dock_add(adev);

		return;

	}

	list_for_each_entry(hwid, &adev->pnp.ids, list) {

		struct acpi_scan_handler *handler;



		handler = acpi_scan_match_handler(hwid->id, NULL);

		if (handler) {

			adev->flags.hotplug_notify = true;

			break;

		}

	}

}



static u32 acpi_scan_check_dep(acpi_handle handle)

{

	struct acpi_handle_list dep_devices;

	u32 count = 0;



	/*

	 * Check for _HID here to avoid deferring the enumeration of:

	 * 1. PCI devices.

	 * 2. ACPI nodes describing USB ports.

	 * Still, checking for _HID catches more then just these cases ...

	 */

	if (!acpi_has_method(handle, "_DEP") || !acpi_has_method(handle, "_HID"))

		return count;



	if (!acpi_evaluate_reference(handle, "_DEP", NULL, &dep_devices)) {

		acpi_handle_debug(handle, "Failed to evaluate _DEP.\n");

		return count;

	}



	count += acpi_scan_add_dep(handle, &dep_devices);

	return count;

}

include/acpi/acpi_bus.h

+1 −0
Original line number Diff line number Diff line
@@ -993,6 +993,7 @@ static inline void acpi_put_acpi_dev(struct acpi_device *adev) 


int acpi_wait_for_acpi_ipmi(void);



int acpi_scan_add_dep(acpi_handle handle, struct acpi_handle_list *dep_devices);

#else	/* CONFIG_ACPI */



static inline int register_acpi_bus_type(void *bus) { return 0; }