Unverified Commit 771f002e authored by Shuicheng Lin's avatar Shuicheng Lin Committed by Rodrigo Vivi
Browse files

drm/xe/uapi: Correct sync type definition in comments 



Commit 37d078e5 ("drm/xe/uapi: Split xe_sync types from flags") renamed some DRM_XE_SYNC_*
defines but later commits kept using the old names. Correct them with the new definition.

v2: correct fixes tag and update commit message to explain why (Lucas)

Fixes: 9329f066 ("drm/xe/uapi: Use LR abbrev for long-running vms")
Fixes: 4b437893 ("drm/xe/uapi: More uAPI documentation additions and cosmetic updates")
Reviewed-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Francois Dugast <francois.dugast@intel.com>
Cc: Zongyao Bai <zongyao.bai@intel.com>
Signed-off-by: default avatarShuicheng Lin <shuicheng.lin@intel.com>
Link: https://lore.kernel.org/r/20250608230133.1250849-1-shuicheng.lin@intel.com


Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent 2ddbb73e

include/uapi/drm/xe_drm.h

+4 −4
Original line number Diff line number Diff line
@@ -925,9 +925,9 @@ struct drm_xe_gem_mmap_offset { 
 *  - %DRM_XE_VM_CREATE_FLAG_LR_MODE - An LR, or Long Running VM accepts

 *    exec submissions to its exec_queues that don't have an upper time

 *    limit on the job execution time. But exec submissions to these

 *    don't allow any of the flags DRM_XE_SYNC_FLAG_SYNCOBJ,

 *    DRM_XE_SYNC_FLAG_TIMELINE_SYNCOBJ, DRM_XE_SYNC_FLAG_DMA_BUF,

 *    used as out-syncobjs, that is, together with DRM_XE_SYNC_FLAG_SIGNAL.

 *    don't allow any of the sync types DRM_XE_SYNC_TYPE_SYNCOBJ,

 *    DRM_XE_SYNC_TYPE_TIMELINE_SYNCOBJ, used as out-syncobjs, that is,

 *    together with sync flag DRM_XE_SYNC_FLAG_SIGNAL.

 *    LR VMs can be created in recoverable page-fault mode using

 *    DRM_XE_VM_CREATE_FLAG_FAULT_MODE, if the device supports it.

 *    If that flag is omitted, the UMD can not rely on the slightly
@@ -1394,7 +1394,7 @@ struct drm_xe_sync { 


	/**

	 * @timeline_value: Input for the timeline sync object. Needs to be

	 * different than 0 when used with %DRM_XE_SYNC_FLAG_TIMELINE_SYNCOBJ.

	 * different than 0 when used with %DRM_XE_SYNC_TYPE_TIMELINE_SYNCOBJ.

	 */

	__u64 timeline_value;