Commit 77427e3d authored by Yongzhi Liu's avatar Yongzhi Liu Committed by Greg Kroah-Hartman
Browse files

misc: microchip: pci1xxxx: Fix a memory leak in the error handling of gp_aux_bus_probe() 



There is a memory leak (forget to free allocated buffers) in a
memory allocation failure path.

Fix it to jump to the correct error handling code.

Fixes: 393fc2f5 ("misc: microchip: pci1xxxx: load auxiliary bus driver for the PIO function in the multi-function endpoint of pci1xxxx device.")
Signed-off-by: default avatarYongzhi Liu <hyperlyzcs@gmail.com>
Reviewed-by: default avatarKumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>
Link: https://lore.kernel.org/r/20240523121434.21855-4-hyperlyzcs@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 086c6cbc

drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c

+4 −2
Original line number Diff line number Diff line
@@ -69,8 +69,10 @@ static int gp_aux_bus_probe(struct pci_dev *pdev, const struct pci_device_id *id 


	aux_bus->aux_device_wrapper[1] = kzalloc(sizeof(*aux_bus->aux_device_wrapper[1]),

						 GFP_KERNEL);

	if (!aux_bus->aux_device_wrapper[1])

		return -ENOMEM;

	if (!aux_bus->aux_device_wrapper[1]) {

		retval =  -ENOMEM;

		goto err_aux_dev_add_0;

	}



	retval = ida_alloc(&gp_client_ida, GFP_KERNEL);

	if (retval < 0)