Commit 776d54c1 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Linus Walleij
Browse files

pinctrl: qcom/lpi: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

To convert all those qcom pinctrl drivers, make msm_pinctrl_remove()
return void (instead of zero) and use .remove_new in all drivers.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20231009162510.335208-2-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 93650550

drivers/pinctrl/qcom/pinctrl-lpass-lpi.c

+1 −3
Original line number Diff line number Diff line
@@ -490,7 +490,7 @@ int lpi_pinctrl_probe(struct platform_device *pdev) 
}

EXPORT_SYMBOL_GPL(lpi_pinctrl_probe);



int lpi_pinctrl_remove(struct platform_device *pdev)

void lpi_pinctrl_remove(struct platform_device *pdev)

{

	struct lpi_pinctrl *pctrl = platform_get_drvdata(pdev);

	int i;
@@ -500,8 +500,6 @@ int lpi_pinctrl_remove(struct platform_device *pdev) 


	for (i = 0; i < pctrl->data->npins; i++)

		pinctrl_generic_remove_group(pctrl->ctrl, i);



	return 0;

}

EXPORT_SYMBOL_GPL(lpi_pinctrl_remove);

drivers/pinctrl/qcom/pinctrl-lpass-lpi.h

+1 −1
Original line number Diff line number Diff line
@@ -85,6 +85,6 @@ struct lpi_pinctrl_variant_data { 
};



int lpi_pinctrl_probe(struct platform_device *pdev);

int lpi_pinctrl_remove(struct platform_device *pdev);

void lpi_pinctrl_remove(struct platform_device *pdev);



#endif /*__PINCTRL_LPASS_LPI_H__*/

drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c

+1 −1
Original line number Diff line number Diff line
@@ -158,7 +158,7 @@ static struct platform_driver lpi_pinctrl_driver = { 
		   .of_match_table = lpi_pinctrl_of_match,

	},

	.probe = lpi_pinctrl_probe,

	.remove = lpi_pinctrl_remove,

	.remove_new = lpi_pinctrl_remove,

};



module_platform_driver(lpi_pinctrl_driver);

drivers/pinctrl/qcom/pinctrl-sc8280xp-lpass-lpi.c

+1 −1
Original line number Diff line number Diff line
@@ -199,7 +199,7 @@ static struct platform_driver lpi_pinctrl_driver = { 
		   .of_match_table = lpi_pinctrl_of_match,

	},

	.probe = lpi_pinctrl_probe,

	.remove = lpi_pinctrl_remove,

	.remove_new = lpi_pinctrl_remove,

};



module_platform_driver(lpi_pinctrl_driver);

drivers/pinctrl/qcom/pinctrl-sm6115-lpass-lpi.c

+1 −1
Original line number Diff line number Diff line
@@ -167,7 +167,7 @@ static struct platform_driver lpi_pinctrl_driver = { 
		.of_match_table = lpi_pinctrl_of_match,

	},

	.probe = lpi_pinctrl_probe,

	.remove = lpi_pinctrl_remove,

	.remove_new = lpi_pinctrl_remove,

};



module_platform_driver(lpi_pinctrl_driver);