Commit 7772dc74 authored by Tariq Toukan's avatar Tariq Toukan Committed by Jakub Kicinski
Browse files

net/mlx5: Disallow SRIOV switchdev mode when in multi-PF netdev 



Adaptations need to be made for the auxiliary device management in the
core driver level. Block this combination for now.

Fixes: 678eb448 ("net/mlx5: SD, Implement basic query and instantiation")
Signed-off-by: default avatarTariq Toukan <tariqt@nvidia.com>
Reviewed-by: default avatarDragos Tatulea <dtatulea@nvidia.com>
Reviewed-by: default avatarGal Pressman <gal@nvidia.com>
Link: https://lore.kernel.org/r/20240409190820.227554-12-tariqt@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 49e6c938

drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c

+7 −0
Original line number Diff line number Diff line
@@ -43,6 +43,7 @@ 
#include "rdma.h"

#include "en.h"

#include "fs_core.h"

#include "lib/mlx5.h"

#include "lib/devcom.h"

#include "lib/eq.h"

#include "lib/fs_chains.h"
@@ -3711,6 +3712,12 @@ int mlx5_devlink_eswitch_mode_set(struct devlink *devlink, u16 mode, 
	if (esw_mode_from_devlink(mode, &mlx5_mode))

		return -EINVAL;



	if (mode == DEVLINK_ESWITCH_MODE_SWITCHDEV && mlx5_get_sd(esw->dev)) {

		NL_SET_ERR_MSG_MOD(extack,

				   "Can't change E-Switch mode to switchdev when multi-PF netdev (Socket Direct) is configured.");

		return -EPERM;

	}



	mlx5_lag_disable_change(esw->dev);

	err = mlx5_esw_try_lock(esw);

	if (err < 0) {