Unverified Commit 7786b106 authored by Cristian Ciocaltea's avatar Cristian Ciocaltea Committed by Mark Brown
Browse files

ASoC: nau8821: Cancel pending work before suspend 



A jack detection work that is unscheduled or in progress while executing
the suspend handler could trigger a race condition.

Ensure state consistency by cancelling any pending work or wait for its
execution to complete before processing the suspend.  Since driver
(re)enables both insert and eject interrupts on resume, there is no risk
to miss the related jack events.  Therefore, flush_delayed_work() is not
required here.

Fixes: aab1ad11 ("ASoC: nau8821: new driver")
Fixes: ee70bace ("ASoC: nau8821: Avoid unnecessary blocking in IRQ handler")
Signed-off-by: default avatarCristian Ciocaltea <cristian.ciocaltea@collabora.com>
Link: https://patch.msgid.link/20251231-nau8821-cleanup-v1-3-6b0b76cbbb64@collabora.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent dbd3fd05

sound/soc/codecs/nau8821.c

+4 −0
Original line number Diff line number Diff line
@@ -1605,6 +1605,10 @@ static int __maybe_unused nau8821_suspend(struct snd_soc_component *component) 


	if (nau8821->irq)

		disable_irq(nau8821->irq);



	if (nau8821->jdet_active)

		cancel_delayed_work_sync(&nau8821->jdet_work);



	snd_soc_dapm_force_bias_level(nau8821->dapm, SND_SOC_BIAS_OFF);

	/* Power down codec power; don't support button wakeup */

	snd_soc_dapm_disable_pin(nau8821->dapm, "MICBIAS");