Commit 77d02290 authored by Breno Leitao's avatar Breno Leitao Committed by Jakub Kicinski
Browse files

rtnetlink: Use nlmsg_payload in valid_fdb_dump_strict 



Leverage the new nlmsg_payload() helper to avoid checking for message
size and then reading the nlmsg data.

Signed-off-by: default avatarBreno Leitao <leitao@debian.org>
Reviewed-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Link: https://patch.msgid.link/20250414-nlmsg-v2-4-3d90cb42c6af@debian.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 2d1f827f

net/core/rtnetlink.c

+2 −2
Original line number Diff line number Diff line
@@ -4887,12 +4887,12 @@ static int valid_fdb_dump_strict(const struct nlmsghdr *nlh, 
	struct ndmsg *ndm;

	int err, i;



	if (nlh->nlmsg_len < nlmsg_msg_size(sizeof(*ndm))) {

	ndm = nlmsg_payload(nlh, sizeof(*ndm));

	if (!ndm) {

		NL_SET_ERR_MSG(extack, "Invalid header for fdb dump request");

		return -EINVAL;

	}



	ndm = nlmsg_data(nlh);

	if (ndm->ndm_pad1  || ndm->ndm_pad2  || ndm->ndm_state ||

	    ndm->ndm_flags || ndm->ndm_type) {

		NL_SET_ERR_MSG(extack, "Invalid values in header for fdb dump request");