Commit 77ed2f45 authored by Hector Martin's avatar Hector Martin Committed by Greg Kroah-Hartman
Browse files

usb: typec: tipd: Use read_power_status function in probe 



We need the initial power status to be able to reliably detect connector
changes once we introduce de-bouncing for CD321x next. read_power_status
takes care of this and also forwards the status to the trace subsystem
so let's use that instead of open-coding it inside probe.

Signed-off-by: default avatarHector Martin <marcan@marcan.st>
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: default avatarNeal Gompa <neal@gompa.dev>
Signed-off-by: default avatarSven Peter <sven@kernel.org>
Link: https://lore.kernel.org/r/20250914-apple-usb3-tipd-v1-9-4e99c8649024@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 36c791c1

drivers/usb/typec/tipd/core.c

+1 −4
Original line number Diff line number Diff line
@@ -1549,11 +1549,8 @@ static int tps6598x_probe(struct i2c_client *client) 
		goto err_role_put;



	if (status & TPS_STATUS_PLUG_PRESENT) {

		ret = tps6598x_read16(tps, TPS_REG_POWER_STATUS, &tps->pwr_status);

		if (ret < 0) {

			dev_err(tps->dev, "failed to read power status: %d\n", ret);

		if (!tps6598x_read_power_status(tps))

			goto err_unregister_port;

		}

		ret = tps6598x_connect(tps, status);

		if (ret)

			dev_err(&client->dev, "failed to register partner\n");