Commit 77fc5151 authored by Jonathan Cameron's avatar Jonathan Cameron
Browse files

device property: Move fwnode_handle_put() into property.h 



By having this function as static inline in the header, the compiler
is able to see if can optmize the call out if (IS_ERR_OR_NULL(fwnode))
This will allow a simpler DEFINE_FREE() call in the following patch.

Suggested-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20240217164249.921878-2-jic23@kernel.org


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 4cece764

drivers/base/property.c

+0 −14
Original line number Diff line number Diff line
@@ -868,20 +868,6 @@ struct fwnode_handle *fwnode_handle_get(struct fwnode_handle *fwnode) 
}

EXPORT_SYMBOL_GPL(fwnode_handle_get);



/**

 * fwnode_handle_put - Drop reference to a device node

 * @fwnode: Pointer to the device node to drop the reference to.

 *

 * This has to be used when terminating device_for_each_child_node() iteration

 * with break or return to prevent stale device node references from being left

 * behind.

 */

void fwnode_handle_put(struct fwnode_handle *fwnode)

{

	fwnode_call_void_op(fwnode, put);

}

EXPORT_SYMBOL_GPL(fwnode_handle_put);



/**

 * fwnode_device_is_available - check if a device is available for use

 * @fwnode: Pointer to the fwnode of the device.

include/linux/property.h

+13 −1
Original line number Diff line number Diff line
@@ -180,7 +180,19 @@ struct fwnode_handle *device_get_named_child_node(const struct device *dev, 
						  const char *childname);



struct fwnode_handle *fwnode_handle_get(struct fwnode_handle *fwnode);

void fwnode_handle_put(struct fwnode_handle *fwnode);



/**

 * fwnode_handle_put - Drop reference to a device node

 * @fwnode: Pointer to the device node to drop the reference to.

 *

 * This has to be used when terminating device_for_each_child_node() iteration

 * with break or return to prevent stale device node references from being left

 * behind.

 */

static inline void fwnode_handle_put(struct fwnode_handle *fwnode)

{

	fwnode_call_void_op(fwnode, put);

}



int fwnode_irq_get(const struct fwnode_handle *fwnode, unsigned int index);

int fwnode_irq_get_byname(const struct fwnode_handle *fwnode, const char *name);