Commit 77feb17c authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

rpmsg: qcom_smd: Fix uninitialized return variable in __qcom_smd_send() 



The "ret" variable isn't initialized if we don't enter the loop.  For
example,  if "channel->state" is not SMD_CHANNEL_OPENED.

Fixes: 33e3820d ("rpmsg: smd: Use spinlock in tx path")
Reported-by: default avatarLinux Kernel Functional Testing <lkft@linaro.org>
Reviewed-by: default avatarAbel Vesa <abel.vesa@linaro.org>
Tested-by: default avatarNaresh Kamboju <naresh.kamboju@linaro.org>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/aAkhvV0nSbrsef1P@stanley.mountain


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 45f0de4f

drivers/rpmsg/qcom_smd.c

+1 −1
Original line number Diff line number Diff line
@@ -746,7 +746,7 @@ static int __qcom_smd_send(struct qcom_smd_channel *channel, const void *data, 
	__le32 hdr[5] = { cpu_to_le32(len), };

	int tlen = sizeof(hdr) + len;

	unsigned long flags;

	int ret;

	int ret = 0;



	/* Word aligned channels only accept word size aligned data */

	if (channel->info_word && len % 4)