Commit 782b6a71 authored by Youngjun Lee's avatar Youngjun Lee Committed by Hans Verkuil
Browse files

media: uvcvideo: Fix 1-byte out-of-bounds read in uvc_parse_format() 



The buffer length check before calling uvc_parse_format() only ensured
that the buffer has at least 3 bytes (buflen > 2), buf the function
accesses buffer[3], requiring at least 4 bytes.

This can lead to an out-of-bounds read if the buffer has exactly 3 bytes.

Fix it by checking that the buffer has at least 4 bytes in
uvc_parse_format().

Signed-off-by: default avatarYoungjun Lee <yjjuny.lee@samsung.com>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Fixes: c0efd232 ("V4L/DVB (8145a): USB Video Class driver")
Cc: stable@vger.kernel.org
Reviewed-by: default avatarRicardo Ribalda <ribalda@chromium.org>
Link: https://lore.kernel.org/r/20250610124107.37360-1-yjjuny.lee@samsung.com


Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarHans Verkuil <hverkuil@xs4all.nl>
parent 53b0b80e

drivers/media/usb/uvc/uvc_driver.c

+3 −0
Original line number Diff line number Diff line
@@ -344,6 +344,9 @@ static int uvc_parse_format(struct uvc_device *dev, 
	u8 ftype;

	int ret;



	if (buflen < 4)

		return -EINVAL;



	format->type = buffer[2];

	format->index = buffer[3];

	format->frames = frames;