Commit 7875c72c authored by Ian Rogers's avatar Ian Rogers Committed by Namhyung Kim
Browse files

perf parse-events: Fix unlikely memory leak when cloning terms 



Add missing free on an error path as detected by clang-tidy.

Signed-off-by: default avatarIan Rogers <irogers@google.com>
Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
Cc: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Yang Jihong <yangjihong1@huawei.com>
Cc: Huacai Chen <chenhuacai@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: llvm@lists.linux.dev
Cc: Ming Wang <wangming01@loongson.cn>
Cc: Tom Rix <trix@redhat.com>
Cc: bpf@vger.kernel.org
Link: https://lore.kernel.org/r/20231009183920.200859-16-irogers@google.com


Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
parent 1370406d

tools/perf/util/parse-events.c

+3 −1
Original line number Diff line number Diff line
@@ -2549,8 +2549,10 @@ int parse_events_term__clone(struct parse_events_term **new, 
		return new_term(new, &temp, /*str=*/NULL, term->val.num);



	str = strdup(term->val.str);

	if (!str)

	if (!str) {

		zfree(&temp.config);

		return -ENOMEM;

	}

	return new_term(new, &temp, str, /*num=*/0);

}