Commit 7885ca40 authored by Mark Harmstone's avatar Mark Harmstone Committed by David Sterba
Browse files

btrfs: fix transaction handle leaks in btrfs_last_identity_remap_gone() 



btrfs_abort_transaction(), unlike btrfs_commit_transaction(), doesn't
also free the transaction handle. Fix the instances in
btrfs_last_identity_remap_gone() where we're also leaking the
transaction on abort.

Reported-by: default avatarChris Mason <clm@fb.com>
Link: https://lore.kernel.org/linux-btrfs/20260125125129.2245240-1-clm@meta.com/


Fixes: 979e1dc3 ("btrfs: handle deletions from remapped block group")
Reviewed-by: default avatarFilipe Manana <fdmanana@suse.com>
Signed-off-by: default avatarMark Harmstone <mark@harmstone.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 54b9395b

fs/btrfs/relocation.c

+3 −0
Original line number Diff line number Diff line
@@ -4723,6 +4723,7 @@ int btrfs_last_identity_remap_gone(struct btrfs_chunk_map *chunk_map, 
	ret = btrfs_remove_dev_extents(trans, chunk_map);

	if (unlikely(ret)) {

		btrfs_abort_transaction(trans, ret);

		btrfs_end_transaction(trans);

		return ret;

	}
@@ -4732,6 +4733,7 @@ int btrfs_last_identity_remap_gone(struct btrfs_chunk_map *chunk_map, 
		if (unlikely(ret)) {

			mutex_unlock(&trans->fs_info->chunk_mutex);

			btrfs_abort_transaction(trans, ret);

			btrfs_end_transaction(trans);

			return ret;

		}

	}
@@ -4750,6 +4752,7 @@ int btrfs_last_identity_remap_gone(struct btrfs_chunk_map *chunk_map, 
	ret = remove_chunk_stripes(trans, chunk_map, path);

	if (unlikely(ret)) {

		btrfs_abort_transaction(trans, ret);

		btrfs_end_transaction(trans);

		return ret;

	}