Commit 789ce196 authored by Chuck Lever's avatar Chuck Lever
Browse files

SUNRPC: Remove BUG_ON call sites 



There is no need to take down the whole system for these assertions.

I'd rather not attempt a heroic save here, as some bug has occurred
that has left the transport data structures in an unknown state.
Just warn and then leak the left-over resources.

Acked-by: default avatarChristian Brauner <brauner@kernel.org>
Reviewed-by: default avatarNeilBrown <neilb@suse.de>
Reviewed-by: default avatarJeff Layton <jlayton@kernel.org>
Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
parent 2929ba9b

net/sunrpc/svc.c

+5 −4
Original line number Diff line number Diff line
@@ -573,11 +573,12 @@ svc_destroy(struct kref *ref) 
	timer_shutdown_sync(&serv->sv_temptimer);



	/*

	 * The last user is gone and thus all sockets have to be destroyed to

	 * the point. Check this.

	 * Remaining transports at this point are not expected.

	 */

	BUG_ON(!list_empty(&serv->sv_permsocks));

	BUG_ON(!list_empty(&serv->sv_tempsocks));

	WARN_ONCE(!list_empty(&serv->sv_permsocks),

		  "SVC: permsocks remain for %s\n", serv->sv_program->pg_name);

	WARN_ONCE(!list_empty(&serv->sv_tempsocks),

		  "SVC: tempsocks remain for %s\n", serv->sv_program->pg_name);



	cache_clean_deferred(serv);