Commit 78c1da52 authored by Weihang Li's avatar Weihang Li Committed by Jason Gunthorpe
Browse files

RDMA/hns: Do not use !! for values that are already bool when calling hr_reg_write() 

There is no need to use "!!" before "eq->eqe_size ==
HNS_ROCE_V3_EQE_SIZE", or sparse will complain about "dubious: x & !y".

Fixes: 782832f2 ("RDMA/hns: Simplify the function config_eqc()")
Link: https://lore.kernel.org/r/1624262443-24528-2-git-send-email-liweihang@huawei.com


Signed-off-by: default avatarWeihang Li <liweihang@huawei.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 1477d44c

drivers/infiniband/hw/hns/hns_roce_hw_v2.c

+1 −2
Original line number Diff line number Diff line
@@ -6264,8 +6264,7 @@ static int config_eqc(struct hns_roce_dev *hr_dev, struct hns_roce_eq *eq, 
	hr_reg_write(eqc, EQC_EQ_CONS_INDX, HNS_ROCE_EQ_INIT_CONS_IDX);

	hr_reg_write(eqc, EQC_NEX_EQE_BA_L, eqe_ba[1] >> 12);

	hr_reg_write(eqc, EQC_NEX_EQE_BA_H, eqe_ba[1] >> 44);

	hr_reg_write(eqc, EQC_EQE_SIZE,

		     !!(eq->eqe_size == HNS_ROCE_V3_EQE_SIZE));

	hr_reg_write(eqc, EQC_EQE_SIZE, eq->eqe_size == HNS_ROCE_V3_EQE_SIZE);



	return 0;

}