Commit 78e39995 authored by Heiko Stuebner's avatar Heiko Stuebner Committed by Tomeu Vizoso
Browse files

accel/rocket: Check the correct DMA irq status to warn about 



Right now, the code checks the DMA_READ_ERROR state 2 times, while
I guess it was supposed to warn about both read and write errors.

Change the 2nd check to look at the write-error flag.

Fixes: 0810d5ad ("accel/rocket: Add job submission IOCTL")
Signed-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
Signed-off-by: default avatarTomeu Vizoso <tomeu@tomeuvizoso.net>
Link: https://lore.kernel.org/r/20250818185658.2585696-1-heiko@sntech.de
parent ce6b656b

drivers/accel/rocket/rocket_job.c

+1 −1
Original line number Diff line number Diff line
@@ -422,7 +422,7 @@ static irqreturn_t rocket_job_irq_handler(int irq, void *data) 
	u32 raw_status = rocket_pc_readl(core, INTERRUPT_RAW_STATUS);



	WARN_ON(raw_status & PC_INTERRUPT_RAW_STATUS_DMA_READ_ERROR);

	WARN_ON(raw_status & PC_INTERRUPT_RAW_STATUS_DMA_READ_ERROR);

	WARN_ON(raw_status & PC_INTERRUPT_RAW_STATUS_DMA_WRITE_ERROR);



	if (!(raw_status & PC_INTERRUPT_RAW_STATUS_DPU_0 ||

	      raw_status & PC_INTERRUPT_RAW_STATUS_DPU_1))