Commit 78ff838a authored by Michał Winiarski's avatar Michał Winiarski
Browse files

drm/xe/pf: Check for fence error on VRAM save/restore 



The code incorrectly assumes that the VRAM save/restore fence is valid.
Fix it by checking for error.

Fixes: 49cf1b9b ("drm/xe/pf: Handle VRAM migration data as part of PF control")
Suggested-by: default avatarMatthew Auld <matthew.auld@intel.com>
Reviewed-by: default avatarMatthew Auld <matthew.auld@intel.com>
Reviewed-by: default avatarMichal Wajdeczko <michal.wajdeczko@intel.com>
Link: https://patch.msgid.link/20251114122339.1791026-1-michal.winiarski@intel.com


Signed-off-by: default avatarMichał Winiarski <michal.winiarski@intel.com>
parent dab751b4

drivers/gpu/drm/xe/xe_gt_sriov_pf_migration.c

+9 −0
Original line number Diff line number Diff line
@@ -571,6 +571,10 @@ static int pf_save_vram_chunk(struct xe_gt *gt, unsigned int vfid, 
	fence = __pf_save_restore_vram(gt, vfid,

				       src_vram, src_vram_offset,

				       data->bo, 0, size, true);

	if (IS_ERR(fence)) {

		ret = PTR_ERR(fence);

		goto fail;

	}



	ret = dma_fence_wait_timeout(fence, false, PF_VRAM_SAVE_RESTORE_TIMEOUT);

	dma_fence_put(fence);
@@ -654,6 +658,11 @@ static int pf_restore_vf_vram_mig_data(struct xe_gt *gt, unsigned int vfid, 


	fence = __pf_save_restore_vram(gt, vfid, vram, data->hdr.offset,

				       data->bo, 0, data->hdr.size, false);

	if (IS_ERR(fence)) {

		ret = PTR_ERR(fence);

		goto err;

	}



	ret = dma_fence_wait_timeout(fence, false, PF_VRAM_SAVE_RESTORE_TIMEOUT);

	dma_fence_put(fence);

	if (!ret) {