Commit 791cd7af authored by Stanley Chang's avatar Stanley Chang Committed by Greg Kroah-Hartman
Browse files

usb: dwc3: add missing of_node_put and platform_device_put 



of_get_compatible_child performs an of_node_get, so an of_node_put is
required. Add platform_device_put to match with of_find_device_by_node.

Fixes: 34c20048 ("usb: dwc3: add Realtek DHC RTD SoC dwc3 glue layer driver")
Signed-off-by: default avatarStanley Chang <stanley_chang@realtek.com>
Acked-by: default avatarThinh Nguyen <Thinh.Nguyen@synopsys.com>
Link: https://lore.kernel.org/r/20231117070311.32502-1-stanley_chang@realtek.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0583bc77

drivers/usb/dwc3/dwc3-rtk.c

+7 −1
Original line number Diff line number Diff line
@@ -183,10 +183,13 @@ static enum usb_device_speed __get_dwc3_maximum_speed(struct device_node *np) 


	ret = of_property_read_string(dwc3_np, "maximum-speed", &maximum_speed);

	if (ret < 0)

		return USB_SPEED_UNKNOWN;

		goto out;



	ret = match_string(speed_names, ARRAY_SIZE(speed_names), maximum_speed);



out:

	of_node_put(dwc3_np);



	return (ret < 0) ? USB_SPEED_UNKNOWN : ret;

}
@@ -339,6 +342,9 @@ static int dwc3_rtk_probe_dwc3_core(struct dwc3_rtk *rtk) 


	switch_usb2_role(rtk, rtk->cur_role);



	platform_device_put(dwc3_pdev);

	of_node_put(dwc3_node);



	return 0;



err_pdev_put: