Commit 79280191 authored by Henrique Carvalho's avatar Henrique Carvalho Committed by Steve French
Browse files

smb: client: fix cifs_pick_channel when channel needs reconnect 



cifs_pick_channel iterates candidate channels using cur. The
reconnect-state test mistakenly used a different variable.

This checked the wrong slot and would cause us to skip a healthy channel
and to dispatch on one that needs reconnect, occasionally failing
operations when a channel was down.

Fix by replacing for the correct variable.

Fixes: fc43a8ac ("cifs: cifs_pick_channel should try selecting active channels")
Cc: stable@vger.kernel.org
Reviewed-by: default avatarShyam Prasad N <sprasad@microsoft.com>
Signed-off-by: default avatarHenrique Carvalho <henrique.carvalho@suse.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent e9a6fb0b

fs/smb/client/transport.c

+1 −1
Original line number Diff line number Diff line
@@ -830,7 +830,7 @@ struct TCP_Server_Info *cifs_pick_channel(struct cifs_ses *ses) 
		if (!server || server->terminate)

			continue;



		if (CIFS_CHAN_NEEDS_RECONNECT(ses, i))

		if (CIFS_CHAN_NEEDS_RECONNECT(ses, cur))

			continue;



		/*