Commit 795b1aa8 authored by Pavan Kumar Linga's avatar Pavan Kumar Linga Committed by Jakub Kicinski
Browse files

idpf: remove redundant 'req_vec_chunks' NULL check 



'req_vec_chunks' is used to store the vector info received
from the device control plane. The memory for it is allocated
in idpf_send_alloc_vectors_msg and returns an error if the memory
allocation fails.

'req_vec_chunks' cannot be NULL in the later code flow. So remove
the conditional check to extract the vector ids received from
the device control plane.

Smatch static checker warning:

drivers/net/ethernet/intel/idpf/idpf_lib.c:417 idpf_intr_req()
error: we previously assumed 'adapter->req_vec_chunks'
could be null (see line 360)

Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/intel-wired-lan/a355ae8a-9011-4a85-a4d1-5b2793bb5f7b@stanley.mountain/


Reviewed-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: default avatarPavan Kumar Linga <pavan.kumar.linga@intel.com>
Tested-by: default avatarKrishneil Singh <krishneil.k.singh@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
Link: https://patch.msgid.link/20240814175903.4166390-1-anthony.l.nguyen@intel.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent aeac0b5e

drivers/net/ethernet/intel/idpf/idpf_lib.c

+5 −18
Original line number Diff line number Diff line
@@ -357,25 +357,12 @@ int idpf_intr_req(struct idpf_adapter *adapter) 
		goto free_msix;

	}



	if (adapter->req_vec_chunks) {

		struct virtchnl2_vector_chunks *vchunks;

		struct virtchnl2_alloc_vectors *ac;



		ac = adapter->req_vec_chunks;

		vchunks = &ac->vchunks;



	num_vec_ids = idpf_get_vec_ids(adapter, vecids, total_vecs,

					       vchunks);

				       &adapter->req_vec_chunks->vchunks);

	if (num_vec_ids < v_actual) {

		err = -EINVAL;

		goto free_vecids;

	}

	} else {

		int i;



		for (i = 0; i < v_actual; i++)

			vecids[i] = i;

	}



	for (vector = 0; vector < v_actual; vector++) {

		adapter->msix_entries[vector].entry = vecids[vector];