Commit 797cc011 authored by Chen Ni's avatar Chen Ni Committed by Lee Jones
Browse files

backlight: sky81452-backlight: Check return value of devm_gpiod_get_optional()... 


backlight: sky81452-backlight: Check return value of devm_gpiod_get_optional() in sky81452_bl_parse_dt()

The devm_gpiod_get_optional() function may return an ERR_PTR in case of
genuine GPIO acquisition errors, not just NULL which indicates the
legitimate absence of an optional GPIO.

Add an IS_ERR() check after the call in sky81452_bl_parse_dt(). On
error, return the error code to ensure proper failure handling rather
than proceeding with invalid pointers.

Fixes: e1915eec ("backlight: sky81452: Convert to GPIO descriptors")
Signed-off-by: default avatarChen Ni <nichen@iscas.ac.cn>
Reviewed-by: default avatarLinus Walleij <linusw@kernel.org>
Reviewed-by: default avatarDaniel Thompson (RISCstar) <danielt@kernel.org>
Link: https://patch.msgid.link/20260203021625.578678-1-nichen@iscas.ac.cn


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent 6de23f81

drivers/video/backlight/sky81452-backlight.c

+3 −0
Original line number Diff line number Diff line
@@ -202,6 +202,9 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt( 
	pdata->dpwm_mode = of_property_read_bool(np, "skyworks,dpwm-mode");

	pdata->phase_shift = of_property_read_bool(np, "skyworks,phase-shift");

	pdata->gpiod_enable = devm_gpiod_get_optional(dev, NULL, GPIOD_OUT_HIGH);

	if (IS_ERR(pdata->gpiod_enable))

		return dev_err_cast_probe(dev, pdata->gpiod_enable,

					  "failed to get gpio\n");



	ret = of_property_count_u32_elems(np, "led-sources");

	if (ret < 0) {