Commit 79b6bb18 authored by Brigham Campbell's avatar Brigham Campbell Committed by Douglas Anderson
Browse files

drm: Remove unused MIPI write seq and chatty functions 



Remove the deprecated mipi_dsi_generic_write_seq() and
mipi_dsi_generic_write_chatty() functions now that they are no longer
used.

Reviewed-by: default avatarDouglas Anderson <dianders@chromium.org>
Signed-off-by: default avatarBrigham Campbell <me@brighamcampbell.com>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20250722015313.561966-4-me@brighamcampbell.com
parent a6adf47d

drivers/gpu/drm/drm_mipi_dsi.c

+3 −31
Original line number Diff line number Diff line
@@ -772,41 +772,13 @@ ssize_t mipi_dsi_generic_write(struct mipi_dsi_device *dsi, const void *payload, 
EXPORT_SYMBOL(mipi_dsi_generic_write);



/**

 * mipi_dsi_generic_write_chatty() - mipi_dsi_generic_write() w/ an error log

 * @dsi: DSI peripheral device

 * @payload: buffer containing the payload

 * @size: size of payload buffer

 *

 * Like mipi_dsi_generic_write() but includes a dev_err()

 * call for you and returns 0 upon success, not the number of bytes sent.

 *

 * Return: 0 on success or a negative error code on failure.

 */

int mipi_dsi_generic_write_chatty(struct mipi_dsi_device *dsi,

				  const void *payload, size_t size)

{

	struct device *dev = &dsi->dev;

	ssize_t ret;



	ret = mipi_dsi_generic_write(dsi, payload, size);

	if (ret < 0) {

		dev_err(dev, "sending generic data %*ph failed: %zd\n",

			(int)size, payload, ret);

		return ret;

	}



	return 0;

}

EXPORT_SYMBOL(mipi_dsi_generic_write_chatty);



/**

 * mipi_dsi_generic_write_multi() - mipi_dsi_generic_write_chatty() w/ accum_err

 * mipi_dsi_generic_write_multi() - mipi_dsi_generic_write() w/ accum_err

 * @ctx: Context for multiple DSI transactions

 * @payload: buffer containing the payload

 * @size: size of payload buffer

 *

 * Like mipi_dsi_generic_write_chatty() but deals with errors in a way that

 * makes it convenient to make several calls in a row.

 * A wrapper around mipi_dsi_generic_write() that deals with errors in a way

 * that makes it convenient to make several calls in a row.

 */

void mipi_dsi_generic_write_multi(struct mipi_dsi_multi_context *ctx,

				  const void *payload, size_t size)

include/drm/drm_mipi_dsi.h

+0 −23
Original line number Diff line number Diff line
@@ -285,8 +285,6 @@ void mipi_dsi_picture_parameter_set_multi(struct mipi_dsi_multi_context *ctx, 


ssize_t mipi_dsi_generic_write(struct mipi_dsi_device *dsi, const void *payload,

			       size_t size);

int mipi_dsi_generic_write_chatty(struct mipi_dsi_device *dsi,

				  const void *payload, size_t size);

void mipi_dsi_generic_write_multi(struct mipi_dsi_multi_context *ctx,

				  const void *payload, size_t size);

void mipi_dsi_dual_generic_write_multi(struct mipi_dsi_multi_context *ctx,
@@ -387,27 +385,6 @@ void mipi_dsi_dcs_set_tear_scanline_multi(struct mipi_dsi_multi_context *ctx, 
					  u16 scanline);

void mipi_dsi_dcs_set_tear_off_multi(struct mipi_dsi_multi_context *ctx);



/**

 * mipi_dsi_generic_write_seq - transmit data using a generic write packet

 *

 * This macro will print errors for you and will RETURN FROM THE CALLING

 * FUNCTION (yes this is non-intuitive) upon error.

 *

 * Because of the non-intuitive return behavior, THIS MACRO IS DEPRECATED.

 * Please replace calls of it with mipi_dsi_generic_write_seq_multi().

 *

 * @dsi: DSI peripheral device

 * @seq: buffer containing the payload

 */

#define mipi_dsi_generic_write_seq(dsi, seq...)                                \

	do {                                                                   \

		static const u8 d[] = { seq };                                 \

		int ret;                                                       \

		ret = mipi_dsi_generic_write_chatty(dsi, d, ARRAY_SIZE(d));    \

		if (ret < 0)                                                   \

			return ret;                                            \

	} while (0)



/**

 * mipi_dsi_generic_write_seq_multi - transmit data using a generic write packet

 *