Commit 79d56805 authored by Junxian Huang's avatar Junxian Huang Committed by Leon Romanovsky
Browse files

RDMA/hns: Fix -Wframe-larger-than issue 



Fix -Wframe-larger-than issue by allocating memory for qpc struct
with kzalloc() instead of using stack memory.

Fixes: 606bf89e ("RDMA/hns: Refactor for hns_roce_v2_modify_qp function")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202506240032.CSgIyFct-lkp@intel.com/


Signed-off-by: default avatarJunxian Huang <huangjunxian6@hisilicon.com>
Link: https://patch.msgid.link/20250703113905.3597124-7-huangjunxian6@hisilicon.com


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent 5338abb2

drivers/infiniband/hw/hns/hns_roce_hw_v2.c

+10 −5
Original line number Diff line number Diff line
@@ -5349,11 +5349,10 @@ static int hns_roce_v2_modify_qp(struct ib_qp *ibqp, 
{

	struct hns_roce_dev *hr_dev = to_hr_dev(ibqp->device);

	struct hns_roce_qp *hr_qp = to_hr_qp(ibqp);

	struct hns_roce_v2_qp_context ctx[2];

	struct hns_roce_v2_qp_context *context = ctx;

	struct hns_roce_v2_qp_context *qpc_mask = ctx + 1;

	struct hns_roce_v2_qp_context *context;

	struct hns_roce_v2_qp_context *qpc_mask;

	struct ib_device *ibdev = &hr_dev->ib_dev;

	int ret;

	int ret = -ENOMEM;



	if (attr_mask & ~IB_QP_ATTR_STANDARD_BITS)

		return -EOPNOTSUPP;
@@ -5364,7 +5363,11 @@ static int hns_roce_v2_modify_qp(struct ib_qp *ibqp, 
	 * we should set all bits of the relevant fields in context mask to

	 * 0 at the same time, else set them to 0x1.

	 */

	memset(context, 0, hr_dev->caps.qpc_sz);

	context = kvzalloc(sizeof(*context), GFP_KERNEL);

	qpc_mask = kvzalloc(sizeof(*qpc_mask), GFP_KERNEL);

	if (!context || !qpc_mask)

		goto out;



	memset(qpc_mask, 0xff, hr_dev->caps.qpc_sz);



	ret = hns_roce_v2_set_abs_fields(ibqp, attr, attr_mask, cur_state,
@@ -5406,6 +5409,8 @@ static int hns_roce_v2_modify_qp(struct ib_qp *ibqp, 
		clear_qp(hr_qp);



out:

	kvfree(qpc_mask);

	kvfree(context);

	return ret;

}