Commit 7a025e06 authored by Tom Rix's avatar Tom Rix Committed by Steven Rostedt (Google)
Browse files

tracing/osnoise: set several trace_osnoise.c variables storage-class-specifier to static 

smatch reports several similar warnings
kernel/trace/trace_osnoise.c:220:1: warning:
  symbol '__pcpu_scope_per_cpu_osnoise_var' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:243:1: warning:
  symbol '__pcpu_scope_per_cpu_timerlat_var' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:335:14: warning:
  symbol 'interface_lock' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:2242:5: warning:
  symbol 'timerlat_min_period' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:2243:5: warning:
  symbol 'timerlat_max_period' was not declared. Should it be static?

These variables are only used in trace_osnoise.c, so it should be static

Link: https://lore.kernel.org/linux-trace-kernel/20230309150414.4036764-1-trix@redhat.com



Signed-off-by: default avatarTom Rix <trix@redhat.com>
Acked-by: default avatarMasami Hiramatsu (Google) <mhiramat@kernel.org>
Acked-by: default avatarDaniel Bristot de Oliveira <bristot@kernel.org>
Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent bc4f359b

kernel/trace/trace_osnoise.c

+5 −5
Original line number Diff line number Diff line
@@ -217,7 +217,7 @@ struct osnoise_variables { 
/*

 * Per-cpu runtime information.

 */

DEFINE_PER_CPU(struct osnoise_variables, per_cpu_osnoise_var);

static DEFINE_PER_CPU(struct osnoise_variables, per_cpu_osnoise_var);



/*

 * this_cpu_osn_var - Return the per-cpu osnoise_variables on its relative CPU
@@ -240,7 +240,7 @@ struct timerlat_variables { 
	u64			count;

};



DEFINE_PER_CPU(struct timerlat_variables, per_cpu_timerlat_var);

static DEFINE_PER_CPU(struct timerlat_variables, per_cpu_timerlat_var);



/*

 * this_cpu_tmr_var - Return the per-cpu timerlat_variables on its relative CPU
@@ -332,7 +332,7 @@ struct timerlat_sample { 
/*

 * Protect the interface.

 */

struct mutex interface_lock;

static struct mutex interface_lock;



/*

 * Tracer data.
@@ -2239,8 +2239,8 @@ static struct trace_min_max_param osnoise_print_stack = { 
/*

 * osnoise/timerlat_period: min 100 us, max 1 s

 */

u64 timerlat_min_period = 100;

u64 timerlat_max_period = 1000000;

static u64 timerlat_min_period = 100;

static u64 timerlat_max_period = 1000000;

static struct trace_min_max_param timerlat_period = {

	.lock	= &interface_lock,

	.val	= &osnoise_data.timerlat_period,