Commit 7a3aaaa9 authored by Matthieu Baerts (NGI0)'s avatar Matthieu Baerts (NGI0) Committed by Jakub Kicinski
Browse files

tools: ynl: fix undefined variable name 

This variable used in the error path was not defined according to Ruff.
msg_format.attr_set is used instead, presumably the one that was
supposed to be used originally.

This is linked to Ruff error F821 [1]:

  An undefined name is likely to raise NameError at runtime.

Fixes: 1769e2be ("tools/net/ynl: Add 'sub-message' attribute decoding to ynl")
Link: https://docs.astral.sh/ruff/rules/undefined-name/

 [1]
Signed-off-by: default avatarMatthieu Baerts (NGI0) <matttbe@kernel.org>
Reviewed-by: default avatarDonald Hunter <donald.hunter@gmail.com>
Reviewed-by: default avatarAsbjørn Sloth Tønnesen <ast@fiberby.net>
Link: https://patch.msgid.link/20250909-net-next-ynl-ruff-v1-1-238c2bccdd99@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 724b22d3

tools/net/ynl/pyynl/lib/ynl.py

+1 −1
Original line number Diff line number Diff line
@@ -746,7 +746,7 @@ class YnlFamily(SpecFamily): 
                subdict = self._decode(NlAttrs(attr.raw, offset), msg_format.attr_set)

                decoded.update(subdict)

            else:

                raise Exception(f"Unknown attribute-set '{attr_space}' when decoding '{attr_spec.name}'")

                raise Exception(f"Unknown attribute-set '{msg_format.attr_set}' when decoding '{attr_spec.name}'")

        return decoded



    def _decode(self, attrs, space, outer_attrs = None):